Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when bin doesn't exist #291

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Better error message when bin doesn't exist #291

merged 2 commits into from
Oct 1, 2024

Conversation

TApplencourt
Copy link
Collaborator

Reported by @zippylab

Before:

applenco@aurora-uan-0011:~> iprof adasd
Traceback (most recent call last):
	5: from /opt/aurora/24.180.0/spack/unified/0.8.0/install/linux-sles15-x86_64/oneapi-2024.07.30.002/thapi-git.ceaabfca6a67a0714c44fea8c49d24fc00559485_master-2il6zxsni7z7edscone7b2py6zeztzyr/bin/iprof:840:in `<main>'
	4: from /opt/aurora/24.180.0/spack/unified/0.8.0/install/linux-sles15-x86_64/oneapi-2024.07.30.002/thapi-git.ceaabfca6a67a0714c44fea8c49d24fc00559485_master-2il6zxsni7z7edscone7b2py6zeztzyr/bin/iprof:649:in `trace_and_on_node_processing'
	3: from /opt/aurora/24.180.0/spack/unified/0.8.0/install/linux-sles15-x86_64/oneapi-2024.07.30.002/thapi-git.ceaabfca6a67a0714c44fea8c49d24fc00559485_master-2il6zxsni7z7edscone7b2py6zeztzyr/bin/iprof:309:in `open'
	2: from /opt/aurora/24.180.0/spack/unified/0.8.0/install/linux-sles15-x86_64/oneapi-2024.07.30.002/thapi-git.ceaabfca6a67a0714c44fea8c49d24fc00559485_master-2il6zxsni7z7edscone7b2py6zeztzyr/bin/iprof:660:in `block in trace_and_on_node_processing'
	1: from /opt/aurora/24.180.0/spack/unified/0.8.0/install/linux-sles15-x86_64/oneapi-2024.07.30.002/thapi-git.ceaabfca6a67a0714c44fea8c49d24fc00559485_master-2il6zxsni7z7edscone7b2py6zeztzyr/bin/iprof:424:in `launch_usr_bin'
/opt/aurora/24.180.0/spack/unified/0.8.0/install/linux-sles15-x86_64/oneapi-2024.07.30.002/thapi-git.ceaabfca6a67a0714c44fea8c49d24fc00559485_master-2il6zxsni7z7edscone7b2py6zeztzyr/bin/iprof:424:in `spawn': No such file or directory - fork failed (Errno::ENOENT)

Now

applenco@x4715c3s4b0n0:~/THAPI/build/ici/bin> ./iprof ze_infoads
./iprof: Can't find executable ze_infoads

Error message copied from mpirun

mpirun -n 1 adasdsd
Can't find executable adasdsd

Code a little ugly to my taste, but was not smart enough to do better. (and fixed a old bug of ensure)

@TApplencourt TApplencourt requested a review from Kerilk September 30, 2024 22:06
TApplencourt
TApplencourt commented Sep 30, 2024
View reviewed changes
xprof/xprof.rb.in Outdated Show resolved Hide resolved
Kerilk
Kerilk reviewed Sep 30, 2024
View reviewed changes
xprof/xprof.rb.in Outdated Show resolved Hide resolved
@TApplencourt
Copy link
Collaborator Author

TApplencourt commented Sep 30, 2024 •
edited
Loading

Pushed, the fix to call sync_d all the time.
This will avoid hanging is some weird people are playing with MPI_RANK_ID to launch different binaries, and one rank doesn't have the binaries (and that they don't use MPI, because if not mpi init will hang in there code, and nothing we can do about it).

@TApplencourt
Copy link
Collaborator Author

Will open another pr with the Sync_daemon renaming (and the yield f) after this one is merged to avoid rebase/conflic

@Kerilk Kerilk merged commit 1d23af6 into master Oct 1, 2024
16 checks passed
@Kerilk Kerilk deleted the better_error_message_when_bin_doesn_exit branch October 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerilk Kerilk Kerilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TApplencourt @Kerilk